fix: Set default value for overwrite to null which by default is false
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to respect the resource switching of this value
3 tasks
bryantbiggs
changed the title
overwrite to null which by default is false
bryantbiggs
approved these changes
Nov 11, 2025
Member
bryantbiggs
left a comment
bryantbiggs
left a comment
There was a problem hiding this comment.
its not really an issue but ... 6 versus half a dozen 🤷🏽♂️
antonbabenko
pushed a commit
that referenced
this pull request
Nov 11, 2025
## [2.0.1](v2.0.0...v2.0.1) (2025-11-11) ### Bug Fixes * Set default value for `overwrite` to `null` which by default is `false` ([#14](#14)) ([58928d0](58928d0))
Member
|
This PR is included in version 2.0.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing correct default for
overwriteper #11 (comment)I've also made a fix against the
v1.2.0tag in its own branch should the module owners want to create av1.2.1from that as well: v1.2.0...rockholla:terraform-aws-ssm-parameter:fix-v1.2/overwrite-param-default-nullMotivation and Context
Just adjusting to more-accurately expose the default behavior of the
aws_ssm_parameterresource:falseoverwrite on initial creation,truethereafter, whereas prior to this change, it would befalsethereafter as a default.Breaking Changes
No, fixing forward
How Has This Been Tested?
The existing tests should still cover this I believe. I will let the module owners decide if additional tests are needed, and happy to continue to help there.
Along w/ running
examples/completeas a validation, I've done some manual apply validation on the current version vs this version and verified things like initial creation/subsequent behavior on applies for overwriting vs not/respecting provider resource default, e.g. thenullvalue explicitly set on the resource does what we expect, and it does.examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request