-
Notifications
You must be signed in to change notification settings - Fork 86
Add testing with PyTest and GitHub Actions workflow #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add testing with PyTest and GitHub Actions workflow #387
Conversation
Can whoever has the correct access please add a reviewer (or more than one) and give me the privileges to add reviewers? In the meantime, does @peytondmurray have any comments, questions, or suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but would you be willing to revert the formatting changes? The diff is harder to look at when there's a lot of formatting changes mixed in with actual content changes. We'll be taking care of those formatting changes in a subsequent PR anyway.
This PR adds config to use pytest to run existing tests. A GitHub Actions workflow is also included. Additionally, there is a composite
setup-env
action that can be used in other workflows that sets up and installs the specified package in the current environment. Separate configs and CI workflow runs are used for the root package,fairness-indicators
, andtensorboard_plugin
.There is one
xfail
ed test that will need to be addressed in future work.