-
Notifications
You must be signed in to change notification settings - Fork 614
use raw ops #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use raw ops #1914
Conversation
You are owner of some files modified in this pull request. |
Related: #1779 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @fsx950223! I believe this is correct, but the serialization/deserialization might break the saved models (for whom also save the input pipeline) due to different registration name.
Hi @seanpmorgan @gabrieldemarmiesse, should we throw some warning to tell users the implementation has changed? Thank you!
It won't influence saved model. Since saved model needs to load custom kernel separately. |
We have a function to load all SO, so as long as we keep the SO somewhere, we won't break existing models. This PR doesn't break existing saved models but it will remove the gradient for the op though |
Because the PR fix AA on TPUs, I believe the above issues shouldn't block it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
Fix #1779.
cc @WindQAQ
Related google/automl#480