Skip to content

Flaky Test Fixes #8357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 24, 2025
Merged

Flaky Test Fixes #8357

merged 9 commits into from
Sep 24, 2025

Conversation

chaptersix
Copy link
Contributor

@chaptersix chaptersix commented Sep 22, 2025 •
edited
Loading

What changed?

  • Callbacks Test: Replaced manual HTTP server setup with httptest.NewServer, added proper timeout handling for channel operations
  • Max Buffered Event Test: Added crypto/rand to generate truly random test data, preventing possible compression optimization by encoders.

Why?

These test periodically fail. We want them to pass consistently.

How did you test it?

  • built
  • run locally and tested manually

chaptersix
chaptersix commented Sep 22, 2025
View reviewed changes
@chaptersix chaptersix changed the title try to fix some flaky tests Flaky Test Fixes Sep 22, 2025
@chaptersix chaptersix marked this pull request as ready for review September 22, 2025 18:45
@chaptersix chaptersix requested a review from a team as a code owner September 22, 2025 18:45
@chaptersix chaptersix changed the title Flaky Test Fixes Flaky Test Fixes and Revert some Get Job ID changes Sep 22, 2025
@chaptersix
Copy link
Contributor Author

https://github.com/temporalio/temporal/actions/runs/17927641611/job/50977596227

@chaptersix
Copy link
Contributor Author

https://github.com/temporalio/temporal/actions/runs/17928234352/job/50979599976

chaptersix
chaptersix commented Sep 23, 2025
View reviewed changes
spkane31
spkane31 reviewed Sep 23, 2025
View reviewed changes
prathyushpv
prathyushpv reviewed Sep 23, 2025
View reviewed changes
@chaptersix chaptersix changed the title Flaky Test Fixes and Revert some Get Job ID changes Flaky Test Fixes Sep 23, 2025
@chaptersix chaptersix merged commit 17f22dd into main Sep 24, 2025
58 checks passed
@chaptersix chaptersix deleted the alex/flake branch September 24, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathyushpv prathyushpv prathyushpv left review comments

@spkane31 spkane31 spkane31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaptersix @prathyushpv @spkane31