Add service specific dial options in rpc factory #8317
+51
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yycptt
reviewed
Sep 12, 2025
|
Please do not link internal tickets/PRs in OSS |
yycptt
approved these changes
Sep 16, 2025
common/resource/fx.go
Outdated
| } | ||
|
|
||
| func getFrontendConnectionDetails( | ||
| func GetFrontendConnectionDetails( |
There was a problem hiding this comment.
nit: no longer need to export this?
There was a problem hiding this comment.
yea, will update along with unit tests
awln-temporal
force-pushed
the
systemWorkerOpsToken
branch
from
23999c4 to
28a3a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This change introduces options for custom dial options per Service Name. No behavior will change in OSS temporal.
How did you test it?
Link to a test plan if any -