Skip to content

Conversation

elkinmilen
Copy link
Contributor

Added a lot of conceptual info and refinements.
There are inline TODOs for the support engineers to address additionally.

Created to additionally address the #5304 from the Reporting repo: https://github.com/telerik/reporting/issues/5304

Added a lot of conceptual info and refinements.
There are inline TODOs for the support engineers to address additionally.
@elkinmilen
Copy link
Contributor Author

@DimitarNikolovv06 please review and apply the TODOs in subsequent commits before merging. Add me as reviewer.

@ivan-h-ivanov Please review for correctness. Based on the article I have 2 ideas for improvement that will make the workflow smoother.

Copy link
Contributor Author

@elkinmilen elkinmilen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I am not allowed to Approve, only to comment, because I am not listed as approver?
I added some minor comments that need to be applied, other than that, I approve the change.
Thank you!

...Actually, probably because I initiated the pull request :)

Go ahead and apply the comments and merge please, @DimitarNikolovv06
Ping me once there is build on UAT, please


## See Also

* [.NET Coded Report Design, No IDE Strings Attached](https://www.telerik.com/blogs/net-coded-report-design-no-ide-strings-attached)
* [How to use Visual Studio Report Designer to edit CS/VB Reports in .NET Projects]({%slug how-to-use-vs-designer-in-dotnet-core%})
* [How to use the Visual Studio Report Designer (.NET Framework) to edit CS/VB Reports in .NET Core Projects]({%slug how-to-use-vs-designer-in-dotnet-core%})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should continue offering this workaround now that we have this workflow. @ighristov what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not Ivan, but I agree that there is no good reason to reference this kb in the article since the new feature should make it unnecessary to use the old workaround. Considering this, I removed the link from the See Also section

Copy link
Contributor

@DimitarNikolovv06 DimitarNikolovv06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DimitarNikolovv06 DimitarNikolovv06 merged commit 77762c4 into master Aug 21, 2025
@DimitarNikolovv06 DimitarNikolovv06 deleted the coded-reports-improvement branch August 21, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants