-
Notifications
You must be signed in to change notification settings - Fork 29
fix: Improve and Extend the Coded Reports article #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a lot of conceptual info and refinements. There are inline TODOs for the support engineers to address additionally.
@DimitarNikolovv06 please review and apply the TODOs in subsequent commits before merging. Add me as reviewer. @ivan-h-ivanov Please review for correctness. Based on the article I have 2 ideas for improvement that will make the workflow smoother. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I am not allowed to Approve, only to comment, because I am not listed as approver?
I added some minor comments that need to be applied, other than that, I approve the change.
Thank you!
...Actually, probably because I initiated the pull request :)
Go ahead and apply the comments and merge please, @DimitarNikolovv06
Ping me once there is build on UAT, please
...desktop-designers/standalone-report-designer/srd-net-working-with-type-report-definitions.md
Outdated
Show resolved
Hide resolved
...desktop-designers/standalone-report-designer/srd-net-working-with-type-report-definitions.md
Outdated
Show resolved
Hide resolved
...desktop-designers/standalone-report-designer/srd-net-working-with-type-report-definitions.md
Outdated
Show resolved
Hide resolved
|
||
## See Also | ||
|
||
* [.NET Coded Report Design, No IDE Strings Attached](https://www.telerik.com/blogs/net-coded-report-design-no-ide-strings-attached) | ||
* [How to use Visual Studio Report Designer to edit CS/VB Reports in .NET Projects]({%slug how-to-use-vs-designer-in-dotnet-core%}) | ||
* [How to use the Visual Studio Report Designer (.NET Framework) to edit CS/VB Reports in .NET Core Projects]({%slug how-to-use-vs-designer-in-dotnet-core%}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should continue offering this workaround now that we have this workflow. @ighristov what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not Ivan, but I agree that there is no good reason to reference this kb in the article since the new feature should make it unnecessary to use the old workaround. Considering this, I removed the link from the See Also section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Added a lot of conceptual info and refinements.
There are inline TODOs for the support engineers to address additionally.
Created to additionally address the #5304 from the Reporting repo: https://github.com/telerik/reporting/issues/5304