feat: improve how to use resource_group in modules

[posquit0]

Summary

Update resource group configuration to use object-based pattern.

Changes

• Update module version from ~> 0.10.0 to ~> 0.12.0
• Replace individual resource_group_* variables with single object variable
• Update all references to use var.resource_group.* structure
• Add resource_group output to each module

Modules Updated

• ecr-repository
• eks-access-entry
• eks-addon
• eks-cluster
• eks-fargate-profile
• eks-iam-access
• eks-node-group

Test Plan

• Review variable changes
• Verify resource-group module references are correct
• Check outputs are properly formatted

[gemini-code-assist]

Summary of Changes

Hello @posquit0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the consistency and usability of resource group configurations within several AWS Terraform modules. By transitioning from individual variables to a single, structured object, it simplifies the module interfaces and enhances the overall maintainability of the infrastructure code. This change provides a more flexible and modern approach to managing resource group settings.

Highlights

• Configuration Refactoring: Refactored resource group configuration across multiple modules to use a single, object-based variable instead of individual variables.
• Module Version Upgrade: Upgraded the internal resource-group module version from ~> 0.10.0 to ~> 0.12.0 in all affected modules.
• Variable Consolidation: Replaced disparate resource_group_enabled, resource_group_name, and resource_group_description variables with a unified resource_group object variable.
• Internal Reference Updates: Updated all internal references within the modules to align with the new var.resource_group.* structure for accessing resource group properties.
• New Module Output: Introduced a resource_group output in each affected module, exposing the ARN and name of the created resource group for better visibility and programmatic access.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the resource group configuration across multiple modules to use a more modern and maintainable object-based pattern. The changes are consistent and well-implemented. I've provided a few suggestions to simplify the logic in the new resource_group outputs for improved readability and to ensure a consistent output structure. Overall, this is a great improvement.

[gemini-code-assist]

The logic for the resource_group output value is a bit complex and can be simplified for better readability. Using a ternary operator makes the intent clearer and ensures a consistent output structure, with arn and name attributes being present (as null) even when the resource group is disabled.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
    arn     = null
    name    = null
  }

[gemini-code-assist]

The logic for the resource_group output value is a bit complex and can be simplified for better readability. Using a ternary operator makes the intent clearer and ensures a consistent output structure, with arn and name attributes being present (as null) even when the resource group is disabled.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
    arn     = null
    name    = null
  }

[gemini-code-assist]

The logic for the resource_group output value is a bit complex and can be simplified for better readability. Using a ternary operator makes the intent clearer and ensures a consistent output structure, with arn and name attributes being present (as null) even when the resource group is disabled.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
    arn     = null
    name    = null
  }

[gemini-code-assist]

The logic for the resource_group output value is a bit complex and can be simplified for better readability. Using a ternary operator makes the intent clearer and ensures a consistent output structure, with arn and name attributes being present (as null) even when the resource group is disabled.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
    arn     = null
    name    = null
  }

[gemini-code-assist]

The logic for the resource_group output value is a bit complex and can be simplified for better readability. Using a ternary operator makes the intent clearer and ensures a consistent output structure, with arn and name attributes being present (as null) even when the resource group is disabled.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
    arn     = null
    name    = null
  }

[gemini-code-assist]

The logic for the resource_group output value is a bit complex and can be simplified for better readability. Using a ternary operator makes the intent clearer and ensures a consistent output structure, with arn and name attributes being present (as null) even when the resource group is disabled.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
    arn     = null
    name    = null
  }

[gemini-code-assist]

The logic for the resource_group output value is a bit complex and can be simplified for better readability. Using a ternary operator makes the intent clearer and ensures a consistent output structure, with arn and name attributes being present (as null) even when the resource group is disabled.

  value = (var.resource_group.enabled && var.module_tags_enabled) ? {
    enabled = true
    arn     = module.resource_group[0].arn
    name    = module.resource_group[0].name
  } : {
    enabled = false
    arn     = null
    name    = null
  }