Skip to content

Conversation

zobront
Copy link
Collaborator

@zobront zobront commented Jan 31, 2025

Lack of TX Ordering:

  • Changed salt to nonce, pulled from storage on the wallet.
  • Increment nonce during all transactions.
  • Updated EIP712 typehashes to match.

EIP712 Compliance:

  • Removed spaces from typehash.

Airdropper Transfer

  • Changed to a call. Not worried about gas usage, so didn't limit.

KeyID Dirty Bits

  • Pull 32 bytes instead of 8 bytes from code, which we know must always be zero.

Zero Free Mem

  • Set salt = 0 during deployment.

Wrong Revert

  • Use mstore8 instead of mstore.

Deploy 1167 Issues

  • Remove empty byte by switching to 0x8C.
  • Update length to 0x35 in the constructor code
  • Change offset to read Key ID to 0x2d.
  • Update predictAddress() to match.
  • Tests passing.

Don't plan to support signer removal or delegate calls, so no changes based on those recommendations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant