Skip to content

🐛 fix ghost participants in events #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🐛 fix ghost participants in events #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a0f1b
:bug: allow deleted members to be removed as event participants
RogueMacro Oct 1, 2025
cd09baf
:bug: remove deleted users from event in updateParticipantsOrder
RogueMacro Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions app/api/events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,13 +503,10 @@ def is_confirmed(request: Request, id: str, token: AccessTokenPayload = Depends(
def remove_participant(request: Request, id: str, uid: str, token: AccessTokenPayload = Depends(authorize_admin)):
db = get_database(request)
event = get_event_or_404(db, id)
member = db.members.find_one({'id': UUID(uid)})

if not member:
raise HTTPException(404, "User could not be found")
uid = UUID(uid)

participant = db.events.find_one({"eid": event["eid"]}, {"participants": {
"$elemMatch": {"id": member["id"]}}})
"$elemMatch": {"id": uid}}})

if not participant:
raise HTTPException(400, "User not joined event!")
Expand All @@ -520,7 +517,7 @@ def remove_participant(request: Request, id: str, uid: str, token: AccessTokenPa
raise HTTPException(400, "User not joined event!")

db.events.update_one({'eid': event['eid']}, {
"$pull": {"participants": {"id": member["id"]}}})
"$pull": {"participants": {"id": uid}}})

return Response(status_code=200)

Expand All @@ -541,6 +538,12 @@ async def reorder_participants(request: Request, id: str, position_update: Parti
raise HTTPException(
400, "Not valid: got invalid or outdated participant list")

participants = [
participant
for participant in participants
if db.members.find_one({'id': participant['id']}) != None
]

for participant in position_update.updateList:
participant = participant.model_dump()
for i, p in enumerate(participants):
Expand Down