crud: refactor optional types to use go-option #498
Conversation
|
Later, I'll add the Tuple and Any type to the go-option library and make the code even more typesafe. |
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
2 times, most recently
from
499ecc6 to
21bd65d
Compare
|
The required changes have been added. |
|
The commit message should be something like: -> |
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
3 times, most recently
from
f2c9c14 to
6ac2dcf
Compare
|
Please, rebase on the |
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
from
6ac2dcf to
161f48c
Compare
The welcome flags for the IPROTO_FEATURE_IS_SYNC functions have been added and IPROTO_FEATURE_INSERT_ARROW for IPROTO_FEATURE_INSERT_ARROW protocol functions. Changed it CHANGELOG.md in the previous version, it was in the wrong version. Changed #466
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
from
161f48c to
154d996
Compare
oleg-jukovec
left a comment
oleg-jukovec
left a comment
There was a problem hiding this comment.
The first commit is useless at now.
(You've move the changelog entry in the first commit and move back it in the second one).
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
from
154d996 to
7561615
Compare
| import ( | ||
| "context" | ||
|
|
||
| "github.com/vmihailenco/msgpack/v5" |
There was a problem hiding this comment.
pls remove this unnecessary change.
| "github.com/stretchr/testify/require" | ||
| "github.com/tarantool/go-iproto" | ||
|
|
||
| "github.com/tarantool/go-option" |
There was a problem hiding this comment.
pls move this go-option import to the previous section. I'd prefer if we'll use strict import structure:
import (
<builtin packages>
<third-party packages>
<project packages>
)
go-option is third-party package in this classification (even if it's hosted in current org). We may adopt goimports style of sorting, but for now i'd suggest to use this one.
|
In general, I rebased to the master, after that the TestBox_Sugar_Schema_UserGrant_NoSu test crashed. I'm sorting it out now, it's not ready yet. |
- Remove: OptUint, OptInt, OptFloat64, OptString, OptBool, OptTuple. - Remove: MakeOptUint, MakeOptInt, MakeOptFloat64, MakeOptString, MakeOptBool, MakeOptTuple. - Update: All option structs to use option.* types. - Add type Any from go-option. - Fix: Test type inconsistencies. Closes #492
babyTsakhes
force-pushed
the
babyTsakhes/gh-492-replace-usage-of-optional-types-in-crud-with-go-option
branch
from
7561615 to
b941191
Compare
|
Maybe it's the test itself. Correct me, but it only crashes in 4 tests. Everything works locally. |
|
So the changes are ready, please take a look. |
Changed #492