Skip to content

Fix Android build on CI #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 29, 2024
Merged

Conversation

uilianries
Copy link
Member

This PR not only fixes the current build for Android but also simplifies its use by consuming the NDK only from the official Ubuntu docker image provided by Github Actions.

Still, there is a window for improvement, like, caching PEGTL to reduce the build time, but this is a second step for a future PR.

@uilianries uilianries self-assigned this Dec 29, 2024
@uilianries uilianries changed the title Use Github integrated Android NDK only [ci] Use Github integrated Android NDK only in order to fix the current build Dec 29, 2024
@uilianries
Copy link
Member Author

@uilianries uilianries merged commit 821c7d8 into taocpp:main Dec 29, 2024
43 of 60 checks passed
@uilianries uilianries changed the title [ci] Use Github integrated Android NDK only in order to fix the current build Fix Android build on CI Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.01%. Comparing base (d5fc49b) to head (2225183).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   74.01%   74.01%           
=======================================
  Files         257      257           
  Lines        9191     9191           
  Branches      804      804           
=======================================
  Hits         6803     6803           
  Misses       1785     1785           
  Partials      603      603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant