libtailscale: drop inet.af dependency, use net/netip #638
+2
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Revisions
HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
raggi
force-pushed
the
raggi/no-inetaf
branch
2 times, most recently
from
fd59cb0 to
2ef1f4b
Compare
WalterHub
approved these changes
Apr 14, 2025
jwhited
reviewed
Apr 14, 2025
libtailscale/net.go
Outdated
| @@ -102,9 +101,12 @@ func (a *App) getInterfaces() ([]netmon.Interface, error) { | |||
|
|
|||
| addrs := strings.Trim(fields[1], " \n") | |||
| for _, addr := range strings.Split(addrs, " ") { | |||
| ip, err := netaddr.ParseIPPrefix(addr) | |||
| ip, err := netip.ParsePrefix(addr) | |||
There was a problem hiding this comment.
nit: We could also net.ParseCIDR() since the goal is to get a *net.IPNet.
jwhited
approved these changes
Apr 14, 2025
Move to the stdlib version, inet.af is bitrotting as a domain and implementation. Updates #cleanup Signed-off-by: James Tucker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to the stdlib version, inet.af is bitrotting as a domain and implementation.
Updates #cleanup