-
-
Notifications
You must be signed in to change notification settings - Fork 502
chore: bump expo to v54, tailwind to v4 #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Co-authored-by: Julius Marminge <[email protected]>
tailwindcss-animate is outdated, You can use tw-animate-css |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mate 👍
will you completely remove nativewind or this is just temporarily till they release v5 in a couple of days? Using only react-native-css will results in losing all the native only class names. a week ago, the nativewind guys mentioned @juliusmarminge and that they could help with the t3-turbo nativewind v5 upgrade pr: |
You're right, you do lose the default nativewind classes, but they can be included by copying whatever is in https://github.com/nativewind/nativewind/blob/main/theme.css Just waiting for a more recent release of react-native-css and I'll update this PR. |
NativeWind 5.0 preview0 finally here. |
yes i get it, but why manually copying and maintaining this? also a lot of ui packages depend on nativewind. btw v5 has been released |
Cause it wasn't released yet :D |
but preview.1 enough to update this PR :) for example react-native-css now in release version |
nodeLinker: hoisted