Skip to content

Warn about untested network drivers #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

disconnect3d
Copy link
Contributor

This commit adds detection for the driver used by the provided network interface and if an untested one is used (like igb, for which things halted for me) a warning is printed.

This may help users to find out that they used wrong interface or a driver.

This commit adds detection for the driver used by the provided network
interface and if an untested one is used (like igb, for which things
halted for me) a warning is printed.

This may help users to find out that they used wrong interface or a
driver.
@sysprogs
Copy link
Owner

sysprogs commented Apr 5, 2023

Thanks, this is a great idea to warn the users about the untested driver, however it has one minor drawback. If the user decides to try KGDBoE nonetheless, they would need to rebuild it again. The current implementation would also break the compatibility with our VisualKernel product, that expects the module to load regardless of the driver.

Perhaps, a more flexible approach would be to have a shell script that checks the current network driver against the list of tested drivers, warns if it's unsupported, and then loads (and possibly builds) the module? It could also save the users the need to manually pass the address of kallsyms_lookup_name when loading the module.

@disconnect3d
Copy link
Contributor Author

I agree. We can put that code out of the module into a script and have additional functionalities added to it like:

  1. build the module
  2. sign the module
  3. load the module with a given network interface which would get kallsyms_lookup_name from /proc/kallsyms and warn about untested drivers

@disconnect3d
Copy link
Contributor Author

Btw it seems we can fetch the kernel module addresses by using kprobes: xcellerator/linux_kernel_hacking#3 (comment)

@sysprogs
Copy link
Owner

sysprogs commented Apr 7, 2023

Agreed, sounds great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants