-
Notifications
You must be signed in to change notification settings - Fork 136
Support dynamic linking #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Currently, only the stage 0 compiler and stage 1 compiler can be generated, and the stage 1 compiler will encounter a Segmentation fault when running. However, the stage 0 compiler can still compile a simple program and run the executable via QEMU: /* test.c */
int main(void)
{
printf("%x %x %x\n", 1, 2, 3);
printf("%x %x %x %x\n", 1, 2, 3, 4);
printf("%x %x %x %x %x\n", 1, 2, 3, 4, 5);
return 0;
} $ out/shecc --dynlink -o test test.c Then, we can use $ arm-linux-gnueabi-readelf --relocs test
Relocation section '.rel.plt' at offset 0x260 contains 2 entries:
Offset Info Type Sym.Value Sym. Name
000102a8 00000116 R_ARM_JUMP_SLOT 00000000 __libc_start_main
000102ac 00000216 R_ARM_JUMP_SLOT 00000000 printf However, I ran the $ qemu-arm -L /usr/arm-linux-gnueabi/ test
1 2 3
1 2 3 40830000
1 2 3 40830000 10224 Notice that the second and third I think this is a potential issue that shecc pushes wrong values to the stack to make (glibc's) |
FWIW, I disassemble the test.asm$ arm-linux-gnueabi-objdump -d test
test: file format elf32-littlearm
Disassembly of section .text:
000100b4 <.text>:
100b4: e3a0b000 mov fp, #0
100b8: e3a0e000 mov lr, #0
100bc: e49d1004 pop {r1} @ (ldr r1, [sp], #4)
100c0: e1a0200d mov r2, sp
100c4: e52d2004 push {r2} @ (str r2, [sp, #-4]!)
100c8: e52d0004 push {r0} @ (str r0, [sp, #-4]!)
100cc: e3a0c000 mov ip, #0
100d0: e52dc004 push {ip} @ (str ip, [sp, #-4]!)
100d4: e30000ec movw r0, #236 @ 0xec
100d8: e3400001 movt r0, #1
100dc: e3a03000 mov r3, #0
100e0: eb000067 bl 0x10284
100e4: e3a0007f mov r0, #127 @ 0x7f
100e8: eb000005 bl 0x10104
100ec: e1a09000 mov r9, r0
100f0: e1a0a001 mov sl, r1
100f4: e3008004 movw r8, #4
100f8: e3408000 movt r8, #0
100fc: e04dd008 sub sp, sp, r8
10100: e1a0c00d mov ip, sp
10104: eb000005 bl 0x10120
10108: e3008004 movw r8, #4
1010c: e3408000 movt r8, #0
10110: e08dd008 add sp, sp, r8
10114: e1a00000 nop @ (mov r0, r0)
10118: e3a07001 mov r7, #1
1011c: ef000000 svc 0x00000000
10120: e1a00009 mov r0, r9
10124: e1a0100a mov r1, sl
10128: eaffffff b 0x1012c
1012c: e50de004 str lr, [sp, #-4]
10130: e3008044 movw r8, #68 @ 0x44
10134: e3408000 movt r8, #0
10138: e04dd008 sub sp, sp, r8
1013c: e3000224 movw r0, #548 @ 0x224
10140: e3400001 movt r0, #1
10144: e3a01001 mov r1, #1
10148: e3a02002 mov r2, #2
1014c: e3a03003 mov r3, #3
10150: e58d0004 str r0, [sp, #4]
10154: e58d1008 str r1, [sp, #8]
10158: e58d200c str r2, [sp, #12]
1015c: e58d3010 str r3, [sp, #16]
10160: e59d0004 ldr r0, [sp, #4]
10164: e59d1008 ldr r1, [sp, #8]
10168: e59d200c ldr r2, [sp, #12]
1016c: e59d3010 ldr r3, [sp, #16]
+ 10170: eb000046 bl 0x10290
10174: e300022e movw r0, #558 @ 0x22e
10178: e3400001 movt r0, #1
1017c: e3a01001 mov r1, #1
10180: e3a02002 mov r2, #2
10184: e3a03003 mov r3, #3
10188: e3a04004 mov r4, #4
1018c: e58d0014 str r0, [sp, #20]
10190: e58d1018 str r1, [sp, #24]
10194: e58d201c str r2, [sp, #28]
10198: e58d3020 str r3, [sp, #32]
1019c: e58d4024 str r4, [sp, #36] @ 0x24
101a0: e59d0014 ldr r0, [sp, #20]
101a4: e59d1018 ldr r1, [sp, #24]
101a8: e59d201c ldr r2, [sp, #28]
101ac: e59d3020 ldr r3, [sp, #32]
101b0: e59d4024 ldr r4, [sp, #36] @ 0x24
+ 101b4: eb000035 bl 0x10290
101b8: e300023b movw r0, #571 @ 0x23b
101bc: e3400001 movt r0, #1
101c0: e3a01001 mov r1, #1
101c4: e3a02002 mov r2, #2
101c8: e3a03003 mov r3, #3
101cc: e3a04004 mov r4, #4
101d0: e3a05005 mov r5, #5
101d4: e58d0028 str r0, [sp, #40] @ 0x28
101d8: e58d102c str r1, [sp, #44] @ 0x2c
101dc: e58d2030 str r2, [sp, #48] @ 0x30
101e0: e58d3034 str r3, [sp, #52] @ 0x34
101e4: e58d4038 str r4, [sp, #56] @ 0x38
101e8: e58d503c str r5, [sp, #60] @ 0x3c
101ec: e59d0028 ldr r0, [sp, #40] @ 0x28
101f0: e59d102c ldr r1, [sp, #44] @ 0x2c
101f4: e59d2030 ldr r2, [sp, #48] @ 0x30
101f8: e59d3034 ldr r3, [sp, #52] @ 0x34
101fc: e59d4038 ldr r4, [sp, #56] @ 0x38
10200: e59d503c ldr r5, [sp, #60] @ 0x3c
+ 10204: eb000021 bl 0x10290
10208: e3a00000 mov r0, #0
1020c: e1a00000 nop @ (mov r0, r0)
10210: e3008044 movw r8, #68 @ 0x44
10214: e3408000 movt r8, #0
10218: e08dd008 add sp, sp, r8
1021c: e51de004 ldr lr, [sp, #-4]
10220: e12fff3e blx lr
Disassembly of section .plt:
00010270 <.plt>:
10270: e52de004 push {lr} @ (str lr, [sp, #-4]!)
10274: e300a2a4 movw sl, #676 @ 0x2a4
10278: e340a001 movt sl, #1
1027c: e1a0e00a mov lr, sl
10280: e59ef000 ldr pc, [lr]
10284: e300c2a8 movw ip, #680 @ 0x2a8
10288: e340c001 movt ip, #1
1028c: e59cf000 ldr pc, [ip]
+ 10290: e300c2ac movw ip, #684 @ 0x2ac
10294: e340c001 movt ip, #1
10298: e59cf000 ldr pc, [ip]
|
b698f38
to
13dfa35
Compare
Consider the minimal change below: --- a/src/main.c
+++ b/src/main.c
@@ -85,7 +85,7 @@ int main(int argc, char *argv[])
global_init();
/* include libc */
- if (libc)
+ if (libc && !dynlink)
libc_generate();
/* load and parse source code into IR */ It disables the built-in libc when |
This suggests that parameter passing is handled differently. Currently, the virtual registers (0-7) are mapped to ARM physical registers (r0-r7). Looking at the code,
In ARM calling convention, arguments beyond r3 should go to the stack, not to r4-r7. This is definitely a bug. When |
The original code had a bug where function calls with more than 4 arguments violated the AAPCS:
However, shecc was incorrectly placing all arguments (0-7) in registers r0-r7, causing stack-based arguments to be passed incorrectly. Consider the changes below: diff --git a/src/reg-alloc.c b/src/reg-alloc.c
index c66a061..51cd2ea 100644
--- a/src/reg-alloc.c
+++ b/src/reg-alloc.c
@@ -520,12 +520,42 @@ void reg_alloc(void)
is_pushing_args = 1;
}
- src0 = prepare_operand(bb, insn->rs1, -1);
- ir = bb_add_ph2_ir(bb, OP_assign);
- ir->src0 = src0;
- ir->dest = args++;
- REGS[ir->dest].var = insn->rs1;
- REGS[ir->dest].polluted = 0;
+ /* Check if next call is to external function (for ARM
+ * calling convention)
+ */
+ insn_t *next_insn = insn->next;
+ func_t *target_func = NULL;
+ bool is_external_call = false;
+
+ /* Look ahead for the OP_call to determine if it's external
+ */
+ while (next_insn && next_insn->opcode == OP_push)
+ next_insn = next_insn->next;
+ if (next_insn && next_insn->opcode == OP_call) {
+ target_func = find_func(next_insn->str);
+ is_external_call = target_func && !target_func->bbs;
+ }
+
+ /* ARM calling convention for external functions: first 4
+ * args in r0-r3, rest on stack
+ */
+ if (is_external_call && args >= 4) {
+ /* Arguments 4+: keep on stack, don't load into
+ * registers. The variable is already on stack from
+ * earlier spill_alive().
+ */
+ } else {
+ /* Normal behavior for internal functions or first 4
+ * args
+ */
+ src0 = prepare_operand(bb, insn->rs1, -1);
+ ir = bb_add_ph2_ir(bb, OP_assign);
+ ir->src0 = src0;
+ ir->dest = args;
+ REGS[ir->dest].var = insn->rs1;
+ REGS[ir->dest].polluted = 0;
+ }
+ args++;
break;
case OP_call:
callee_func = find_func(insn->str);
@@ -535,8 +565,8 @@ void reg_alloc(void)
ir = bb_add_ph2_ir(bb, OP_call);
strcpy(ir->func_name, insn->str);
if (dynlink) {
- func_t *target_func = find_func(ir->func_name);
- target_func->is_used = true;
+ func_t *target_fn = find_func(ir->func_name);
+ target_fn->is_used = true;
}
is_pushing_args = 0; Before the fix: All arguments were always loaded into sequential registers (r0, r1, r2, r3, r4, r5, r6, r7).
Before Fix (Incorrect)
After Fix (Correct)
|
Consider the changes below to avoid duplications: (conceptual) diff --git a/lib/c.c b/lib/c.c
index 29ed2c8..5b57e26 100644
--- a/lib/c.c
+++ b/lib/c.c
@@ -7,48 +7,10 @@
/* minimal libc implementation */
-#define NULL 0
-
-#define bool _Bool
-#define true 1
-#define false 0
-
-#define INT_MAX 0x7fffffff
-#define INT_MIN 0x80000000
-
-#if defined(__arm__)
-#define __SIZEOF_POINTER__ 4
-#define __syscall_exit 1
-#define __syscall_read 3
-#define __syscall_write 4
-#define __syscall_close 6
-#define __syscall_open 5
-#define __syscall_mmap2 192
-#define __syscall_munmap 91
-
-#elif defined(__riscv)
-#define __SIZEOF_POINTER__ 4
-#define __syscall_exit 93
-#define __syscall_read 63
-#define __syscall_write 64
-#define __syscall_close 57
-#define __syscall_open 1024
-#define __syscall_openat 56
-#define __syscall_mmap2 222
-#define __syscall_munmap 215
-
-#else /* Only Arm32 and RV32 are supported */
-#error "Unsupported architecture"
-#endif
+#include "c.h"
#define INT_BUF_LEN 16
-typedef int FILE;
-
-/* va_list support for variadic functions */
-typedef int *va_list;
-
-void abort(void);
int strlen(char *str)
{
diff --git a/lib/c.h b/lib/c.h
index 1406568..4d4eb5f 100644
--- a/lib/c.h
+++ b/lib/c.h
@@ -5,23 +5,62 @@
* file "LICENSE" for information on usage and redistribution of this file.
*/
+#ifndef SHECC_LIBC_H
+#define SHECC_LIBC_H
+
+/* Standard definitions */
#define NULL 0
#define bool _Bool
#define true 1
#define false 0
+#define INT_MAX 0x7fffffff
+#define INT_MIN 0x80000000
...
+#endif /* SHECC_LIBC_H */ |
I would like to ask @lecopzer for reviewing. |
The proposed changes enhance shecc to generate dynamically linked executables. When the
--dynlink
flag is specified, shecc produces sections such as.plt
and.got
for the compiled programs, allowing the executables to leverage the ELF interpreter and the GNU C library to run.This pull request is still a work in progress due to the following incomplete tasks:
README.md
to describe dynamic linking.Updated usage: