Support ~ in virtio-blk paths and improve error handling #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Oct 19, 2025
There was a problem hiding this comment.
Benchmarks
| Benchmark suite | Current: 457f621 | Previous: ddde83c | Ratio |
|---|---|---|---|
Dhrystone |
1340 Average DMIPS over 10 runs |
1286 Average DMIPS over 10 runs |
0.96 |
Coremark |
935.86 Average iterations/sec over 10 runs |
951.961 Average iterations/sec over 10 runs |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="src/riscv.c">
<violation number="1" location="src/riscv.c:705">
Guard against vblk_opts[0] being NULL before checking for '~' so delimiter-only inputs don't crash.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
This commit allows the virtio block device to resolve disk image paths starting with ~ to the user's home directory, making it more convenient. Additionally, it adds error handling for cases where the -x vblk: option is used without specifying a path.
ChinYikMing
force-pushed
the
support-home-dir-vblk
branch
from
ddde83c to
457f621
Compare
|
Thank @ChinYikMing for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows the virtio block device to resolve disk image paths starting with ~ to the user's home directory, making it more convenient. Additionally, it adds error handling for cases where the -x vblk: option is used without specifying a path.
Testing
Expectation
GuestOS is bootable and
~/disk_test.imgis accessible via/dev/vda.Summary by cubic
Enable ~ expansion in virtio-blk disk paths and add clear errors for invalid input. Users can now pass ~/disk.img; we resolve it to HOME and fail fast on empty paths or missing HOME.
New Features
Bug Fixes