refactor: move MCP tools to a separate package #29
+66
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the MCP tools codebase by moving tool implementations from the mcp package to a separate tools sub-package, improving code organization and package structure.
Key Changes:
- Tool implementation files moved from
package mcptopackage tools - Test files updated to use
package tools_testwith proper import aliases - References updated throughout the codebase to use the new
toolspackage
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| internal/infra/mcp/tools/utils.go | Updated package declaration from mcp to tools |
| internal/infra/mcp/tools/tools_suite_test.go | Added new test suite file for the tools package |
| internal/infra/mcp/tools/tool_run_sysql_test.go | Updated test package and added imports for separated packages |
| internal/infra/mcp/tools/tool_run_sysql.go | Updated package declaration from mcp to tools |
| internal/infra/mcp/tools/tool_list_runtime_events_test.go | Updated test package and added imports for separated packages |
| internal/infra/mcp/tools/tool_list_runtime_events.go | Updated package declaration from mcp to tools |
| internal/infra/mcp/tools/tool_get_event_process_tree_test.go | Updated test package and added imports for separated packages |
| internal/infra/mcp/tools/tool_get_event_process_tree.go | Updated package declaration from mcp to tools |
| internal/infra/mcp/tools/tool_get_event_info_test.go | Updated test package and added imports for separated packages |
| internal/infra/mcp/tools/tool_get_event_info.go | Updated package declaration from mcp to tools |
| internal/infra/mcp/tools/tool_generate_sysql_test.go | Updated test package and added imports for separated packages |
| internal/infra/mcp/tools/tool_generate_sysql.go | Updated package declaration from mcp to tools |
| internal/infra/mcp/mcp_handler_test.go | Updated reference to use tools.WithRequiredPermissions |
| internal/infra/mcp/mcp_handler.go | Updated references to use tools package for utility functions |
| cmd/server/main.go | Updated tool constructor calls to use tools package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alecron
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.