Removed <key>dmdg</key> and added a detection for Apple Monitors. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit mainly removed <key>dmdg</key> since this is useless for our non-Apple monitors. And we can do nothing for Apple Monitors. So if the VID = 0x610 (Apple) and then exit.
PMheart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit mainly removed dmdg since this is useless for our non-Apple monitors. And we can do nothing for Apple Monitors. So if the VID = 0x610 (Apple) and then exit.
We discussed this on Facebook yesterday. And today I updated the code. Unfortunately there is no document for the detailed action of dmdg. Nevertheless I can sure that this can do nothing for us. I didn’t know if you noticed that there are many keys inside DisplayVendorID-610, and dmdg is just one of them. Anyway, I removed it.
And like above. I think DisplayVendorID-610 is mysterious. Many unknown keys existed. And we don’t know what will happen after adding these ones. So just remove them anyway. I did a detection for VID = 0x610 (Apple). Just have a look about my this commit.
Anyway. Thanks for your effort on HiDPI.