-
-
Notifications
You must be signed in to change notification settings - Fork 272
Fix incorrectly generated Swagger docs for /labelmaker/asset/{id} route
#1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe Asset label endpoint route annotation was updated from the plural form Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Security & compatibility notes:
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
🔇 Additional comments (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
/labelmaker/asset/{id} route
What type of PR is this?
What this PR does / why we need it:
This PR fixes incorrectly generated swagger docs by fixing the relevant comment line in
v1_ctrl_labelmaker.goto match the route inroutes.go:homebox/backend/app/api/routes.go
Line 172 in a379e7c
Also see #1077 .
Which issue(s) this PR fixes:
Addresses #1077 .
Testing
I have not tested the Swagger documentation autogeneration, but I think this change is unlikely to break it.
Summary by CodeRabbit
/v1/labelmaker/assets/{id}to/v1/labelmaker/asset/{id}.