Update ldk node version to 0.7.0 #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovitrif
approved these changes
Dec 4, 2025
Collaborator
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
tACK
Tested send unconfirmed funds, right after new wallet + fund via dev settings > blocktank regtest, without mining.
Found a bug in iOS, not related to this though. I tested the same flow and it works in Android.
spendUnconfirmediOS.mov
Should be fixed separately, not in scope of this PR.
Collaborator
|
Feel free to merge once after CI passes. |
Contributor
Author
|
e2e is failing, not sure why exactly, @piotr-iohk can you please take a look? |
Collaborator
|
@ben-kaufman passing now. Sorry, it is due to the divergence on e2e tests related to onchain events not merged yet on Android. Therefore for the time being I need to create specific branch on e2e (based of synonymdev/bitkit-e2e-tests#56) for each iOS change. |
pwltr
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates LDK node version to 0.7.0
Also updates LDK node config to count unconfirmed incoming balances as spendable