-
-
Couldn't load subscription status.
- Fork 388
[TwigComponent][Perf] Remove component dumping from profiler to reduce memory usage #3066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT @kbond?
|
So i checked on the project I work on and .... I'm not a big fan of this idea (but not against the idea of not storing the components ... but) Multiple data are only visible here in the profiler... and basic scalar data is not something that would take that much memory (at all). Could you maybe create a repository / share some code (or context) to understand what numver of components (or what amount of inner data) becomes a problem in dev for you ? I'd rather we change profiling and remove an important feature of it only if we have a concrete example to base this choice on.... |
|
Since having components dumps in the profiler is useful but could become a mess on memory usage when having too much components, what about introducing a new option This option could be |
100%, something I suggested here but forgot to move back here (my bad) |
|
Status: Needs work |
This PR removes the component object dumping from the Symfony UX Twig Component profiler to address memory consumption issues.
IMHO, the component dump is not necessary in the profiler as it can be quite verbose and memory-intensive. When detailed component inspection is needed, it's preferable to dump the component manually in the specific context where debugging is required.