Skip to content

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented May 29, 2025

Currently, when requiring symfony/panther, Flex adds the following two lines to phpunit.dist.xml:

<extensions>
+    <bootstrap class="Symfony\Component\Panther\ServerExtension" />
+    <extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>

This isn't entirely correct: the extension tag is used for PHPUnit <10, while bootstrap is used for PHPUnit >=10.

This PR adds support for specifying the required package version for each line, so only the appropriate one is added.

Recipes PR: symfony/recipes#1422

@HypeMC HypeMC force-pushed the add-version-to-add-lines-requires branch from 24b10a8 to 3319fcf Compare May 29, 2025 18:02
@fabpot
Copy link
Member

fabpot commented Jul 4, 2025

Thank you @HypeMC.

@fabpot fabpot merged commit b502cb0 into symfony:2.x Jul 4, 2025
6 of 7 checks passed
@HypeMC HypeMC deleted the add-version-to-add-lines-requires branch July 4, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants