-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[6.2] Bypass lifetime diagnostics in interfaces for copied arguments. #81118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atrick
wants to merge
10
commits into
swiftlang:release/6.2
Choose a base branch
from
atrick:62-rdar146319009-borrow-constraint
base: release/6.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[6.2] Bypass lifetime diagnostics in interfaces for copied arguments. #81118
atrick
wants to merge
10
commits into
swiftlang:release/6.2
from
atrick:62-rdar146319009-borrow-constraint
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bb9e52c)
(cherry picked from commit 0603645)
Handle parameters with no name: foo(_:T) (cherry picked from commit a7c9b6e)
A small typo meant that scoped dependencies modeled with mark_dependence_addr were not diagnosed. (cherry picked from commit 92b2a85)
Diagnose a scoped dependence on an argument that inherits its lifetime as an error: @Lifetime(borrow arg) func reborrowSpan<T>(_ arg: Span<T>) -> Span<T> { arg } @Lifetime(copy span) public func testBorrowInheritedArg<T>(_ span: Span<T>) -> Span<T> { reborrowSpan(span) // expected-error {{lifetime-dependent value escapes its scope}} } Fixes: rdar://146319009 ([nonescapable] enforce borrow constraint narrowing of inherited lifetime) (cherry picked from commit 4f470a1)
(cherry picked from commit 49a8770)
The implementation previously took advantage of a missing diagnostic. They returned a borrowed Span with a dependency on a copied argument. This illegally promotes the dependency. This is what the author intended to do (the implementation was correct) but the compiler can't know that so the code needs to be explicit about overriding the lifetime. (cherry picked from commit e9d1128)
(cherry picked from commit 4ef3b4f)
rdar://150073405 ([SILGen] support synthesized _modify on top of borrowed getters with library evolution) (cherry picked from commit 78758da)
Briefly (April 2025), RawSpan._extracting, Span._extracting, and UTF8Span.span returned a borrowed value that depended on a copied argument. Continue to support those interfaces. The implementations were correct but needed an explicit _overrideLifetime. (cherry picked from commit 8a48cd9)
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main PR: #81105
LifetimeDependenceScopeFixup: cleanup for clarity
(cherry picked from commit bb9e52c)
[NFC] LifetimeDependenceUtils comment
(cherry picked from commit 0603645)
Fix LifetimeDependence attribute checking
Handle parameters with no name: foo(_:T)
(cherry picked from commit a7c9b6e)
Fix LifetimeDependenceDiagnostics: handle mark_dependence_addr
A small typo meant that scoped dependencies modeled with mark_dependence_addr
were not diagnosed.
(cherry picked from commit 92b2a85)
Fix LifetimeDependenceDiagnostics: scoped dependence on a copy
Diagnose a scoped dependence on an argument that inherits its lifetime as an
error:
@Lifetime(borrow arg)
func reborrowSpan(_ arg: Span) -> Span { arg }
@Lifetime(copy span)
public func testBorrowInheritedArg(_ span: Span) -> Span {
reborrowSpan(span) // expected-error {{lifetime-dependent value escapes its scope}}
}
Fixes: rdar://146319009 ([nonescapable] enforce borrow constraint narrowing of inherited lifetime)
(cherry picked from commit 4f470a1)
Add .swiftinterface tests to check backward compatibility.
(cherry picked from commit 49a8770)
Add _overrideLifetime to Span APIs
The implementation previously took advantage of a missing diagnostic. They
returned a borrowed Span with a dependency on a copied argument. This illegally
promotes the dependency. This is what the author intended to do (the
implementation was correct) but the compiler can't know that so the code needs
to be explicit about overriding the lifetime.
(cherry picked from commit e9d1128)
Update tests for stricter diagnostics on borrowed argument lifetime
(cherry picked from commit 4ef3b4f)
Disable a test until SILGen supports borrowing getter + library evo
rdar://150073405 ([SILGen] support synthesized _modify on top of borrowed
getters with library evolution)
(cherry picked from commit 78758da)
Bypass lifetime diagnostics in interfaces for copied arguments.
Briefly (April 2025), RawSpan._extracting, Span._extracting, and UTF8Span.span
returned a borrowed value that depended on a copied argument. Continue to
support those interfaces. The implementations were correct but needed an
explicit _overrideLifetime.
(cherry picked from commit 8a48cd9)