Skip to content

[6.2] [Sema] Add missing null check for Type #81083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #81025

  • Explanation: Fixes a crash that could occur when performing code completion
  • Scope: Affects code completion
  • Issue: rdar://149759542
  • Risk: Low, adds a null check
  • Testing: Added tests to test suite
  • Reviewer: Pavel Yaskevich

`getType` here can return a null type if the queried expression isn't
part of the solution, which can currently happen for code completion.
I'm working on a more principled fix for this, but until then this is
a low-risk fix that will unblock the stress tester and can be
cherry-picked to 6.2.

rdar://149759542
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Apr 24, 2025
@hamishknight hamishknight requested a review from bnbarham April 24, 2025 19:40
@hamishknight hamishknight requested a review from a team as a code owner April 24, 2025 19:40
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight enabled auto-merge April 24, 2025 20:39
@hamishknight hamishknight merged commit 1dfd519 into swiftlang:release/6.2 Apr 25, 2025
5 checks passed
@hamishknight hamishknight deleted the add-null-check-6.2 branch April 25, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants