[6.2][Sema] ConstnessChecker: Look through function conversions while chec… #81051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king arguments In strict concurrency mode some calls could reference a declaration that is wrapped in one or more function conversion expressions to apply concurrency related attributes or erase them (such as `@Sendable` or `@MainActor`). This shouldn't impact constness checking and the checker should look through such conversions. Resolves: rdar://148168219 (cherry picked from commit b484e96)
|
@swift-ci please test |
bnbarham
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…king arguments
Cherry-pick of #81049
Explanation:
Avoid false-positive diagnostics about non-constant arguments in some APIs.
In strict concurrency mode some calls could reference a declaration that is wrapped in one or more function conversion expressions to apply concurrency related attributes or erase them (such as
@Sendableor@MainActor). This shouldn't impact constness checking and the checker should look through such conversions.Main Branch PR: [Sema] ConstnessChecker: Look through function conversions while chec… #81049
Risk: Low (This change should be no-op because no swift interfaces are expected to be using the names yet).
Reviewed By: @slavapestov
Resolves: rdar://148168219
Testing: Added new tests to the Sema test suite.
(cherry picked from commit b484e96)