[6.2] AST: Quote attributes more consistently in diagnostics #81038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test macOS |
slavapestov
approved these changes
Apr 24, 2025
|
@swift-ci please test |
hborla
approved these changes
Apr 25, 2025
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: We are supposed to quote anything that is referred to as code, and attributes are no exception. This change makes quoting consistent for attributes that are hardcoded or passed via a string parameter.
Cherry-picking to sync. The amount of files modified here is likely to cause many future cherry-picks to hit conflicts otherwise.
Scope: Diagnostic messages.
Issues: —
Original PRs: AST: Quote attributes more consistently in diagnostics #80593
Risk: Low. Diagnostic definition changes only.
Testing: Updated verified diagnostics.
Reviewers: @xedin