Skip to content

[swift-snapshot-tool] Two small fixes #80834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

[swift-snapshot-tool] Two small fixes #80834

merged 2 commits into from
Apr 16, 2025
+16 −5

Conversation

gottesmm
Copy link
Contributor

Just fixed this while using the tool to bisect some already fixed issues:

  1. I changed it so that run doesn't take a full tag name and instead just takes a date like bisect does. Normalizing to just use the date makes sense since one shouldn't have to type swift-DEVELOPMENT-SNAPSHOT-YYYY-MM-DD-a instead of YYYY-MM-DD.
  2. I noticed that when comparing dates to determine the tag to use, I was using < instead of <=. This meant that when one knew the exact tag to start bisecting at or running at, we always chose the one before it.

gottesmm added 2 commits April 15, 2025 13:02
@gottesmm
[swift_snapshot_tool] Make the run command just accept a date like bi…
c8dbbc3 
…sect does.

Previously, we wanted a full tag name, but that is really not needed. Better to
harmonize the two and eliminate the need for a full tag name.
@gottesmm
[swift_snapshot_tool] Use <= instead of < then when determining the t…
a2da134 
…ag to use for the date.

Otherwise, if one knows the specific date one wants to use, one always uses the
tag before it which is annoying.
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm gottesmm enabled auto-merge April 15, 2025 20:04
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test linux platform

@gottesmm gottesmm merged commit 49260b7 into swiftlang:main Apr 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gottesmm