Skip to content

[LifetimeDependenceMutableAccessors] defensive feature flag #80831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Apr 15, 2025

Adds a feature flag for mutable getters that return non-escapable results.

The feature flag introduced here is intended to guard mutating accessors that return non-escapable types, because this combination crashes an older version of the compiler as it parses the swiftinterface file.

Addresses rdar://149227278

@glessard glessard requested review from atrick and meg-gupta April 15, 2025 17:54
@glessard
Copy link
Contributor Author

@swift-ci please smoke test

@glessard
Copy link
Contributor Author

@swift-ci please smoke test linux platform

1 similar comment
@glessard
Copy link
Contributor Author

@swift-ci please smoke test linux platform

@glessard glessard marked this pull request as ready for review April 16, 2025 05:25
@glessard glessard requested a review from porglezomp April 16, 2025 05:25
@glessard glessard merged commit a5c561f into swiftlang:main Apr 17, 2025
3 checks passed
@glessard glessard deleted the rdar149227278-nonescapable-mutating-accessor branch April 17, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant