[CoroutineAccessors] Only reference when available #80828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
rdar148783895
branch
2 times, most recently
from
eaa63f1 to
547a820
Compare
Several callers of `AbstractStorageDecl::getAccessStrategy` only cared about whether the the access would be via physical storage. Before adding more arguments to `getAccessStrategy` for which such callers would have to pass a sentinel value, add a convenience method for this.
Don't bind references to storage to use (new ABI) coroutine accessors unless they're guaranteed to be available. For example, when building against a resilient module that has coroutine accessors, they can only be used if the deployment target is >= the version of Swift that includes the feature. rdar://148783895
nate-chandler
force-pushed
the
rdar148783895
branch
2 times, most recently
from
3723b43 to
7697a49
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
jckarter
approved these changes
Apr 16, 2025
nate-chandler
requested review from
rjmccall,
hborla,
xedin and
slavapestov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bind references to storage to use (new ABI) coroutine accessors unless they're guaranteed to be available. For example, when building against a resilient module that has coroutine accessors, they can only be used if the deployment target is >= the version of Swift that includes the feature.
rdar://148783895