CI: Enable Wasm Swift SDK build #3135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkebo
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
kkebo
force-pushed
the
enable-wasm-ci
branch
2 times, most recently
from
2aa93a0 to
1a874b0
Compare
|
@swift-ci test |
MaxDesiatov
reviewed
Aug 27, 2025
| @@ -10,6 +10,8 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #if !os(WASI) | |||
There was a problem hiding this comment.
Should the whole file be excluded? Does all of it rely on dlopen and dynamic linking or are there any parts that we could keep enabled?
There was a problem hiding this comment.
Nothing useful IMO - LibraryPluginProvider is all about loading libraries and is only used in tools/swift-plugin-server in swift.
There was a problem hiding this comment.
I agree with @bnbarham. That's why I did this.
bnbarham
approved these changes
Aug 27, 2025
| @@ -10,6 +10,8 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| #if !os(WASI) | |||
There was a problem hiding this comment.
Nothing useful IMO - LibraryPluginProvider is all about loading libraries and is only used in tools/swift-plugin-server in swift.
|
@swift-ci please test |
|
@swift-ci test windows |
MaxDesiatov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us to prevent regressions like #2944.
(By the way, we can even run tests on a Wasm runtime if we add more changes. However, I don't think it's a good time to do that since swiftlang/github-workflows does not support such a workflow yet.)