build: add support for installing the image #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replicates much of the logic from the new runtimes build to support installing the Swift interface and the runtime components. Additionally, we are now able to generate the targets configuration to allow dependencies between projects.
jakepetroules
approved these changes
Jul 16, 2025
jakepetroules
requested changes
Jul 16, 2025
There was a problem hiding this comment.
CMake Error at cmake/modules/PlatformInfo.cmake:30 (string):
string sub-command JSON member 'target platform' not found.
Call Stack (most recent call first):
CMakeLists.txt:25 (include)
CMake Error at cmake/modules/PlatformInfo.cmake:38 (string):
string sub-command JSON member 'target arch' not found.
Call Stack (most recent call first):
CMakeLists.txt:25 (include)
|
okay, so seems like we are going to need a backwards compatibility path for this as we need to target 6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates much of the logic from the new runtimes build to support installing the Swift interface and the runtime components. Additionally, we are now able to generate the targets configuration to allow dependencies between projects.