Tests: Migrate PluginsBuildPlanTests to SwiftTesting and augment #9058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_PluginBuildPlan_to_ST_and_augment
branch
from
797f864 to
4b724e5
Compare
|
@swift-ci test self hosted |
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_PluginBuildPlan_to_ST_and_augment
branch
from
4b724e5 to
cc31932
Compare
|
@swift-ci test self hosted |
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_PluginBuildPlan_to_ST_and_augment
branch
from
cc31932 to
d05981c
Compare
|
@swift-ci test self hosted |
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_PluginBuildPlan_to_ST_and_augment
branch
from
d05981c to
107d103
Compare
|
@swift-ci test self hosted windows |
|
Retriggering build at the previous build failure was no longer available on Jenkins. @swift-ci test self hosted windows |
|
WIndows self hosted pipeline passed. Trigger all self hosted pipelines @swift-ci test self hosted |
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_PluginBuildPlan_to_ST_and_augment
branch
from
107d103 to
2936bbc
Compare
|
@swift-ci test self hosted |
|
@swift-ci test self hosted windows |
|
@swift-ci smoke test |
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci smoke test |
Migrate the `PluginsBuildPlanTests` suite to Swift Testing and, where applicable, augment the test to run against both the Native and SwiftBuild build system, in addition to the `debug` and `release` build configurations. Depends on: swiftlang#9013 Relates to: swiftlang#8997 issue: rdar://157669245
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate_PluginBuildPlan_to_ST_and_augment
branch
from
2936bbc to
c4b01ff
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bripeticca
reviewed
Sep 11, 2025
| swiftSDK: .hostSwiftSDK(environment: [:]), | ||
| environment: [:] | ||
| ) | ||
| // let hostTriple = try! hostToolchain.targetTriple.withoutVersion().tripleString |
There was a problem hiding this comment.
nit: was this accidentally left in?
| localFileSystem.exists( | ||
| fixturePath.appending(RelativePath(".build/\(hostTriple)/debug/plugintool-tool")) | ||
| try await fixture(name: "Miscellaneous/Plugins/CommandPluginTestStub") { fixturePath in | ||
| // let hostBinPath: AbsolutePath = fixturePath.appending(components: hostBinPathSegments) |
jakepetroules
approved these changes
Sep 11, 2025
bkhouri
deleted the
t/main/gh8997_rdar157669245_migrate_PluginBuildPlan_to_ST_and_augment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the
PluginsBuildPlanTestssuite to Swift Testing and, where applicable, augment the test to run against both the Native and SwiftBuild build system, in addition to thedebugandreleasebuild configurations.Depends on: #9013
Relates to: #8997
issue: rdar://157669245