[ST-NNNN] Polling Confirmations #2926
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
the
TWG
stmontgomery
reviewed
Aug 1, 2025
stmontgomery
added
the
workgroup: needs development
grynspan
reviewed
Sep 9, 2025
younata
changed the title
younata
force-pushed
the
younata/testing-polling-expectations
branch
from
c602e5f to
4fafc61
Compare
Contributor
|
Looks like there's some merge or rebase issue, files besides the new proposal are being shown as modified |
younata
force-pushed
the
younata/testing-polling-expectations
branch
from
93f586d to
3fcb851
Compare
Contributor
Author
Whoops. That's corrected now. I wonder how I messed up that rebase. |
…to evaluate the expression after it passes
I'm working on it, but macros are hard.
- Change the default timeout. - Change how unexpected thrown errors are treated. - Add future direction to add change monitoring via Observation - Add alternative considered of Just Use A While Loop - Add alternative considered for shorter default timeouts
- Include commenting on why not pure counts (i.e. why counts + interval) - Specify the configuration traits - Specify callsite configuration of counts + interval
… do not have a configurable clock
…n on when polling should not be used.
Co-authored-by: Jonathan Grynspan <[email protected]>
…t to mention that duration may be greater than or equal to interval
Minor grammar improvements
younata
force-pushed
the
younata/testing-polling-expectations
branch
from
3fcb851 to
3ab257e
Compare
ktoso
reviewed
Dec 2, 2025
| until stopCondition: PollingStopCondition, | ||
| within duration: Duration? = nil, | ||
| pollingEvery interval: Duration? = nil, | ||
| isolation: isolated (any Actor)? = #isolation, |
Contributor
There was a problem hiding this comment.
Prefer expressing this by making the function “nonisolated(nonsending)”
Contributor
Author
There was a problem hiding this comment.
Thanks! I clearly missed the SE proposal that changed this.
ktoso
reviewed
Dec 2, 2025
| pollingEvery interval: Duration? = nil, | ||
| isolation: isolated (any Actor)? = #isolation, | ||
| sourceLocation: SourceLocation = #_sourceLocation, | ||
| _ body: @escaping () async throws -> Bool |
Contributor
There was a problem hiding this comment.
Should this be nonisolated nonsending as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New proposal for Swift Testing: Polling Confirmations.
These allow test authors to check that state updates over the course of some amount of time, in a very brute-force kind of way. Very helpful when there aren't other means of checking this available.