Skip to content

build: Install libraries in an arch sub-folder #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

build: Install libraries in an arch sub-folder #889

wants to merge 6 commits into from
+44 −14

Conversation

Steelskin
Copy link
Contributor

This is the proper installation scheme for Swift libraries and prevents having to manually copy them in build.ps1.

@Steelskin
build: Install libraries in an arch sub-folder
e73dc2b 
This is the proper installation scheme for Swift libraries and prevents
having to manually copy them in `build.ps1`.
@Steelskin
Copy link
Contributor Author

@swift-ci please smoke test

compnerd
compnerd requested changes Jul 23, 2025
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are updating this, we should be using the new tooling that we have been adding into the runtimes build. There is already a pending change of mine that needs to be refreshed for this.

@Steelskin Steelskin requested a review from compnerd August 4, 2025 18:57
@Steelskin
Copy link
Contributor Author

If we are updating this, we should be using the new tooling that we have been adding into the runtimes build. There is already a pending change of mine that needs to be refreshed for this.

I changed this to get the arch value from the compiler. Is this what you had in mind?

compnerd
compnerd reviewed Aug 5, 2025
View reviewed changes
@Steelskin
Get the platform name from the compiler
3eff559 
This also refactors the code so we only do a single call to the Swift
compiler to gather the target info JSON.
@Steelskin Steelskin requested a review from compnerd August 5, 2025 18:38
@Steelskin
Copy link
Contributor Author

@swift-ci please smoke test

@Steelskin
Copy link
Contributor Author

@swift-ci please test

@compnerd
Copy link
Member

compnerd commented Aug 6, 2025

@swift-ci please test Windows platform

@compnerd
Copy link
Member

compnerd commented Aug 6, 2025

@swift-ci please test Linux platform

compnerd
compnerd reviewed Aug 6, 2025
View reviewed changes
@Steelskin
Copy link
Contributor Author

@swift-ci please test windows platform

@Steelskin
Copy link
Contributor Author

@swift-ci please test linux platform

@Steelskin Steelskin requested review from compnerd and etcwilde August 6, 2025 16:59
@Steelskin
Copy link
Contributor Author

@swift-ci please test Windows platform

@Steelskin
Copy link
Contributor Author

@swift-ci please test linux platform

@Steelskin
Copy link
Contributor Author

@swift-ci please test Windows platform

@Steelskin
Copy link
Contributor Author

@swift-ci please test Linux platform

@Steelskin
Copy link
Contributor Author

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akmorrison akmorrison Awaiting requested review from akmorrison

@al45tair al45tair Awaiting requested review from al45tair

@compnerd compnerd Awaiting requested review from compnerd

@etcwilde etcwilde Awaiting requested review from etcwilde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Steelskin @compnerd @etcwilde