[NFC][LLDB] Make it possible to detect if the compiler used in tests supports -fbounds-safety #11885
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supports -fbounds-safety This patch makes it possible to detect in LLDB shell and API tests if `-fbounds-safety` is supported by the compiler used for testing. The motivation behind this is to allow upstreaming swiftlang#11835 but with the tests disabled in upstream because the full implementation of -fbounds-safety isn't available in Clang yet. For shell tests when -fbounds-safety is available the `clang-bounds-safety` feature is available which means tests can be annotated with `# REQUIRES: clang-bounds-safety`. API tests that need -fbounds-safety support in the compiler can use the new `@skipUnlessBoundsSafety` decorator. rdar://165225507
delcypher
requested review from
Michael137,
adrian-prantl,
hnrklssn,
jasonmolenda,
jimingham,
medismailben,
patrykstefanski and
rapidsna
Author
|
Ignore this. I targeted the wrong repo. The actual PR is llvm#169112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it possible to detect in LLDB shell and API tests if
-fbounds-safetyis supported by the compiler used for testing. The motivation behind this is to allow upstreaming #11835 but with the tests disabled in upstream because the full implementation of -fbounds-safety isn't available in Clang yet.For shell tests when -fbounds-safety is available the
clang-bounds-safetyfeature is available which means tests can be annotated with# REQUIRES: clang-bounds-safety.API tests that need -fbounds-safety support in the compiler can use the new
@skipUnlessBoundsSafetydecorator.rdar://165225507