Skip to content

[libclang][reproducers] Redirect writing output to the reproducer cache directory. #11853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

[libclang][reproducers] Redirect writing output to the reproducer cache directory. #11853

merged 1 commit into from
Nov 20, 2025
+16 −4

Conversation

@vsapsai
Copy link

@vsapsai vsapsai commented Nov 19, 2025

The intention is to keep reproducers relocatable. Without redirection we are trying to write output to "/some/path/existing/only/where/reproducer/generated.o" and failing to do so. Instead we redirect the output to the reproducer cache directory which is a relative path that is guaranteed to exist.

.pcm files are the output too but we don't redirect them because they should be written and read from a specific place which is controlled by LookupOutput callback.

@vsapsai
[libclang][reproducers] Redirect writing output to the reproducer cac…
997ebda 
…he directory.

The intention is to keep reproducers relocatable. Without redirection we are
trying to write output to "/some/path/existing/only/where/reproducer/generated.o"
and failing to do so. Instead we redirect the output to the reproducer cache
directory which is a relative path that is guaranteed to exist.

.pcm files are the output too but we don't redirect them because they
should be written and read from a specific place which is controlled by
`LookupOutput` callback.
@vsapsai
Copy link
Author

vsapsai commented Nov 19, 2025

@swift-ci test

1 similar comment
@vsapsai
Copy link
Author

vsapsai commented Nov 20, 2025

@swift-ci test

@vsapsai
Copy link
Author

vsapsai commented Nov 20, 2025

On Linux CI failed with

/home/build-user/swift/lib/Basic/Platform.cpp:232:22: error: no member named 'NaCl' in 'llvm::Triple'; did you mean 'NVCL'?

On macOS it failed with

/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:32:99: error: '_Tp' does not refer to a value
   32 | struct _LIBCPP_NO_SPECIALIZATIONS is_nothrow_convertible : bool_constant<__is_nothrow_convertible(_Tp, _Up)> {};
      |                                                                                                   ^
/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:31:17: note: declared here
   31 | template <class _Tp, class _Up>
      |                 ^
/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:32:104: error: '_Up' does not refer to a value
   32 | struct _LIBCPP_NO_SPECIALIZATIONS is_nothrow_convertible : bool_constant<__is_nothrow_convertible(_Tp, _Up)> {};
      |                                                                                                        ^
/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:31:28: note: declared here
   31 | template <class _Tp, class _Up>
      |                            ^
/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:35:102: error: '_Tp' does not refer to a value
   35 | _LIBCPP_NO_SPECIALIZATIONS inline constexpr bool is_nothrow_convertible_v = __is_nothrow_convertible(_Tp, _Up);
      |                                                                                                      ^
/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:34:17: note: declared here
   34 | template <class _Tp, class _Up>
      |                 ^
/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:35:107: error: '_Up' does not refer to a value
   35 | _LIBCPP_NO_SPECIALIZATIONS inline constexpr bool is_nothrow_convertible_v = __is_nothrow_convertible(_Tp, _Up);
      |                                                                                                           ^
/Users/ec2-user/jenkins/workspace/apple-llvm-project-pr-macos/branch-next/build/buildbot_incremental/libcxx-macosx-x86_64/include/c++/v1/__type_traits/is_convertible.h:34:28: note: declared here
   34 | template <class _Tp, class _Up>
      |                            ^

On Windows it failed with

Error: Error: cmake.exe exited with code 1.
Invocation:
  C:\Program Files\CMake\bin\cmake.exe --build T:\5 --target install-distribution
Call stack:
  at Invoke-Program, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1075
  at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1968
  at Invoke-IsolatingEnvVars, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1094
  at Build-CMakeProject, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1548
  at Build-Compilers, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 2335
  at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 855
  at Record-OperationTime, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 671
  at Invoke-BuildStep, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 854
  at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 4249

    at Invoke-Program, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1079
    at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1968
    at Invoke-IsolatingEnvVars, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1094
    at Build-CMakeProject, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1548
    at Build-Compilers, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 2335
    at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 855
    at Record-OperationTime, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 671
    at Invoke-BuildStep, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 854
    at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 4249
  From System.Management.Automation.RuntimeException: Error: cmake.exe exited with code 1.
  Invocation:
    C:\Program Files\CMake\bin\cmake.exe --build T:\5 --target install-distribution
  Call stack:
    at Invoke-Program, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1075
    at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1968
    at Invoke-IsolatingEnvVars, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1094
    at Build-CMakeProject, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 1548
    at Build-Compilers, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 2335
    at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 855
    at Record-OperationTime, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 671
    at Invoke-BuildStep, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 854
    at <ScriptBlock>, C:\Users\swift-ci\jenkins\workspace\apple-llvm-project-pull-request-windows\swift\utils\build.ps1: line 4249

All the errors are pre-existing and not relevant to the change currently being made.

@vsapsai vsapsai merged commit 87d0b80 into swiftlang:next Nov 20, 2025
0 of 3 checks passed
@vsapsai vsapsai deleted the reproducer-redirect-output-to-reproducer-cache branch November 20, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vsapsai