Skip to content

[lldb] remove unittest2 from tests #11084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

charles-zablit
Copy link

From unittest2's Readme: unittest2 is a backport of the new features added to the unittest testing framework in Python 2.7 and onwards. It is tested to run on Python 2.6, 2.7, 3.2, 3.3, 3.4 and pypy.

Since, we use Python 3.9.10 to test LLDB, there is no need for unittest2 anymore.

This patch is a follow up to d26912d, which removes the use of unittest2 in all of LLDB testing.

@charles-zablit charles-zablit requested a review from a team as a code owner July 30, 2025 09:22
@charles-zablit
Copy link
Author

I have not tested this at desk yet, I want to make sure this does not break any tests on any platforms.

cc @felipepiovezan since you removed the import unittest2.

@charles-zablit
Copy link
Author

@swift-ci please test

@charles-zablit
Copy link
Author

@swift-ci please test windows

Copy link

@felipepiovezan felipepiovezan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised we never detected this before!

@charles-zablit
Copy link
Author

@swift-ci please clean test Windows platform

@charles-zablit
Copy link
Author

@swift-ci please test windows

1 similar comment
@charles-zablit
Copy link
Author

@swift-ci please test windows

@charles-zablit
Copy link
Author

@swift-ci please test

@adrian-prantl adrian-prantl merged commit 54ea957 into swiftlang:swift/release/6.2 Aug 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants