Skip to content

Conversation

sebsto
Copy link
Contributor

@sebsto sebsto commented Sep 1, 2025

Fixes #553

@sebsto sebsto requested a review from Copilot September 1, 2025 10:56
@sebsto sebsto self-assigned this Sep 1, 2025
@sebsto sebsto added the 🔨 semver/patch No public API change. label Sep 1, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the timeout function to withTimeout in test utilities to improve naming consistency and clarity. The change addresses issue #553 by adopting a more descriptive function name that follows Swift naming conventions.

Key changes:

  • Renamed timeout function to withTimeout in test utilities
  • Updated all function call sites to use the new name
  • Fixed a minor spelling error in a comment

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
Tests/AWSLambdaRuntimeTests/Timeout.swift Renamed function from timeout to withTimeout
Tests/AWSLambdaRuntimeTests/LambdaRuntimeClientTests.swift Updated function call to use new withTimeout name
Sources/AWSLambdaRuntime/LambdaRuntimeClient.swift Fixed spelling error in comment ("eror" → "error")

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sebsto sebsto changed the title Rename Tests' timeout(0 function Rename Tests' timeout() function Sep 1, 2025
@sebsto sebsto merged commit ec28c96 into swift-server:main Sep 1, 2025
35 checks passed
@sebsto sebsto deleted the sebsto/timeout branch September 1, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] - move Timeout code from example to core
1 participant