Skip to content

Add staleDate to APNSStartLiveActivityNotification #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

Add staleDate to APNSStartLiveActivityNotification #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Sources/APNSCore/LiveActivity/APNSStartLiveActivityNotification.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ public struct APNSStartLiveActivityNotification<Attributes: Encodable & Sendable
/// - timestamp: Timestamp when sending notification
/// - dismissalDate: Timestamp when to dismiss live notification when sent with `end`, if in the past
/// dismiss immediately
/// - staleDate: Timestamp when the notification is marked as stale
/// - apnsID: A canonical UUID that identifies the notification.
/// - attributes: The ActivityAttributes of the live activity to start
/// - attributesType: The type name of the ActivityAttributes you want to send
Expand All @@ -113,6 +114,7 @@ public struct APNSStartLiveActivityNotification<Attributes: Encodable & Sendable
contentState: ContentState,
timestamp: Int,
dismissalDate: APNSLiveActivityDismissalDate = .none,
staleDate: Int? = nil,
apnsID: UUID? = nil,
attributes: Attributes,
attributesType: String,
Expand All @@ -122,6 +124,7 @@ public struct APNSStartLiveActivityNotification<Attributes: Encodable & Sendable
timestamp: timestamp,
contentState: contentState,
dismissalDate: dismissalDate.dismissal,
staleDate: staleDate,
alert: alert,
attributes: attributes,
attributesType: attributesType
Expand Down
4 changes: 4 additions & 0 deletions Sources/APNSCore/LiveActivity/APNSStartLiveActivityNotificationAPSStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ struct APNSStartLiveActivityNotificationAPSStorage<Attributes: Encodable & Senda
case event = "event"
case contentState = "content-state"
case dismissalDate = "dismissal-date"
case staleDate = "stale-date"
case alert = "alert"
case attributes = "attributes"
case attributesType = "attributes-type"
Expand All @@ -29,6 +30,7 @@ struct APNSStartLiveActivityNotificationAPSStorage<Attributes: Encodable & Senda
var event: String = "start"
var contentState: ContentState
var dismissalDate: Int?
var staleDate: Int?
var alert: APNSAlertNotificationContent
var attributes: Attributes
var attributesType: String
Expand All @@ -37,13 +39,15 @@ struct APNSStartLiveActivityNotificationAPSStorage<Attributes: Encodable & Senda
timestamp: Int,
contentState: ContentState,
dismissalDate: Int?,
staleDate: Int?,
alert: APNSAlertNotificationContent,
attributes: Attributes,
attributesType: String
) {
self.timestamp = timestamp
self.contentState = contentState
self.dismissalDate = dismissalDate
self.staleDate = staleDate
self.alert = alert
self.attributes = attributes
self.attributesType = attributesType
Expand Down
4 changes: 3 additions & 1 deletion Tests/APNSTests/LiveActivity/APNSLiveActivityNotificationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ final class APNSLiveActivityNotificationTests: XCTestCase {
appID: "test.app.id",
contentState: State(),
timestamp: 1_672_680_658,
staleDate: 1_672_680_800,
attributes: Attributes(),
attributesType: "Attributes",
alert: .init(title: .raw("Hi"), body: .raw("Hello"))
Expand All @@ -115,7 +116,8 @@ final class APNSLiveActivityNotificationTests: XCTestCase {
let data = try encoder.encode(notification)

let expectedJSONString = """
{"aps":{"event":"start", "alert": { "title": "Hi", "body": "Hello" }, "attributes-type": "Attributes", "attributes": {"name":"Test Attribute"},"content-state":{"string":"Test","number":123},"timestamp":1672680658}}
{"aps":{"event":"start", "alert": { "title": "Hi", "body": "Hello" }, "attributes-type": "Attributes", "attributes": {"name":"Test Attribute"},"content-state":{"string":"Test","number":123},"timestamp":1672680658,
"stale-date":1672680800}}
"""

let jsonObject1 = try JSONSerialization.jsonObject(with: data) as! NSDictionary
Expand Down