fix: various mac build fixes and improvements [DIP-311]

cc/BUILD.bazel

@@ -16,7 +16,7 @@ exports_files(
     visibility = ["//visibility:public"],
 )
 
-# Disable tests and test libraries with --@rules_swiftnav//:disable_test=true
+# Disable tests and test libraries with --@rules_swiftnav///cc:disable_test=true
 bool_flag(
     name = "disable_tests",
     build_setting_default = False,
@@ -29,7 +29,7 @@ config_setting(
     visibility = ["//visibility:public"],
 )
 
-# Enable exceptions with --@rules_swiftnav//:enable_exceptions=true
+# Enable exceptions with --@rules_swiftnav//cc:enable_exceptions=true
 bool_flag(
     name = "enable_exceptions",
     build_setting_default = False,
@@ -42,7 +42,7 @@ config_setting(
     visibility = ["//visibility:public"],
 )
 
-# Enable rtti with --@rules_swiftnav//:enable_exceptions=true
+# Enable rtti with --@rules_swiftnav//cc:enable_exceptions=true
 bool_flag(
     name = "enable_rtti",
     build_setting_default = False,
@@ -55,6 +55,19 @@ config_setting(
     visibility = ["//visibility:public"],
 )
 
+# Enable shared linking with --@rules_swiftnav//cc:enable_shared=true
+bool_flag(
+    name = "enable_shared",
+    build_setting_default = False,
+    visibility = ["//visibility:public"],
+)
+
+config_setting(
+    name = "_enable_shared",
+    flag_values = {":enable_shared": "true"},
+    visibility = ["//visibility:public"],
+)
+
 # Disable warnings as errors with --@rules_swiftnav//cc:warnings_as_errors=false
 bool_flag(
     name = "warnings_as_errors",
@@ -75,21 +88,21 @@ string_flag(
     visibility = ["//visibility:public"],
 )
 
-# Enable with --@rules_swiftnav//:cxx_standard=17
+# Enable with --@rules_swiftnav//cc:cxx_standard=17
 config_setting(
     name = "cxx17",
     flag_values = {":cxx_standard": "17"},
     visibility = ["//visibility:public"],
 )
 
-# Enable with --@rules_swiftnav//:cxx_standard=20
+# Enable with --@rules_swiftnav//cc:cxx_standard=20
 config_setting(
     name = "cxx20",
     flag_values = {":cxx_standard": "20"},
     visibility = ["//visibility:public"],
 )
 
-# Enable with --@rules_swiftnav//:cxx_standard=23
+# Enable with --@rules_swiftnav//cc:cxx_standard=23
 config_setting(
     name = "cxx23",
     flag_values = {":cxx_standard": "23"},

cc/defs.bzl

@@ -77,6 +77,12 @@ def _common_cxx_opts(exceptions = False, rtti = False, standard = None):
 def _construct_local_includes(local_includes):
     return [construct_local_include(path) for path in local_includes]
 
+def _link_static(linkstatic = True):
+    return select({
+        Label("//cc:_enable_shared"): False,
+        "//conditions:default": linkstatic,
+    })
+
 # Disable building when --//:disable_tests=true or when building on windows
 def _test_compatible_with():
     return select({
@@ -220,6 +226,8 @@ def swift_c_library(**kwargs):
 
     kwargs["tags"] = [LIBRARY] + kwargs.get("tags", [])
 
+    kwargs["linkstatic"] = _link_static(kwargs.get("linkstatic", True))
+
     native.cc_library(**kwargs)
 
 def swift_cc_library(**kwargs):
@@ -271,6 +279,8 @@ def swift_cc_library(**kwargs):
 
     kwargs["tags"] = [LIBRARY] + kwargs.get("tags", [])
 
+    kwargs["linkstatic"] = _link_static(kwargs.get("linkstatic", True))
+
     native.cc_library(**kwargs)
 
 def swift_c_tool_library(**kwargs):
@@ -313,6 +323,8 @@ def swift_c_tool_library(**kwargs):
 
     kwargs["copts"] = copts + c_standard + kwargs.get("copts", [])
 
+    kwargs["linkstatic"] = _link_static(kwargs.get("linkstatic", True))
+
     native.cc_library(**kwargs)
 
 def swift_cc_tool_library(**kwargs):
@@ -358,6 +370,8 @@ def swift_cc_tool_library(**kwargs):
 
     kwargs["copts"] = copts + cxxopts + kwargs.get("copts", [])
 
+    kwargs["linkstatic"] = _link_static(kwargs.get("linkstatic", True))
+
     native.cc_library(**kwargs)
 
 def swift_c_binary(**kwargs):
@@ -404,6 +418,8 @@ def swift_c_binary(**kwargs):
 
     kwargs["tags"] = [BINARY] + kwargs.get("tags", [])
 
+    kwargs["linkstatic"] = _link_static(kwargs.get("linkstatic", True))
+
     native.cc_binary(**kwargs)
 
 def swift_cc_binary(**kwargs):
@@ -568,6 +584,8 @@ def swift_cc_test_library(**kwargs):
 
     kwargs["target_compatible_with"] = kwargs.get("target_compatible_with", []) + _test_compatible_with()
 
+    kwargs["linkstatic"] = _link_static(kwargs.get("linkstatic", True))
+
     native.cc_library(**kwargs)
 
 def swift_cc_test(name, type, **kwargs):

cc/toolchains/llvm/cc_toolchain_config.bzl

@@ -108,12 +108,6 @@ def cc_toolchain_config(
         use_lld = False
         link_flags.extend([
             "-headerpad_max_install_names",
-            # This will issue a warning on macOS ventura; see:
-            # https://github.com/python/cpython/issues/97524
-            # https://developer.apple.com/forums/thread/719961
-            "-undefined",
-            "dynamic_lookup",
-            "-Wl,-no_fixup_chains",
         ])
     else:
         use_lld = True

cc/toolchains/llvm/unix_cc_toolchain_config.bzl

@@ -29,6 +29,11 @@ load(
 )
 load("@bazel_tools//tools/build_defs/cc:action_names.bzl", "ACTION_NAMES")
 
+def _target_os_version(ctx):
+    platform_type = ctx.fragments.apple.single_arch_platform.platform_type
+    xcode_config = ctx.attr._xcode_config[apple_common.XcodeVersionConfig]
+    return xcode_config.minimum_os_for_platform_type(platform_type)
+
 def layering_check_features(compiler):
     if compiler != "clang":
         return []
@@ -1283,6 +1288,17 @@ def _impl(ctx):
         ],
     )
 
+    macos_minimum_os_feature = feature(
+        name = "macos_minimum_os",
+        enabled = True,
+        flag_sets = [
+            flag_set(
+                actions = all_compile_actions + all_link_actions,
+                flag_groups = [flag_group(flags = ["-mmacos-version-min={}".format(_target_os_version(ctx))])],
+            ),
+        ],
+    )
+
     is_linux = ctx.attr.target_libc != "macosx"
     libtool_feature = feature(
         name = "libtool",
@@ -1365,6 +1381,7 @@ def _impl(ctx):
             asan_feature,
             tsan_feature,
             ubsan_feature,
+            macos_minimum_os_feature,
         ] + (
             [
                 supports_start_end_lib_feature,
@@ -1431,6 +1448,11 @@ cc_toolchain_config = rule(
         "coverage_link_flags": attr.string_list(),
         "supports_start_end_lib": attr.bool(),
         "builtin_sysroot": attr.string(),
+        "_xcode_config": attr.label(default = configuration_field(
+            fragment = "apple",
+            name = "xcode_config_label",
+        )),
     },
+    fragments = ["apple"],
     provides = [CcToolchainConfigInfo],
 )

third_party/check.BUILD

@@ -22,6 +22,10 @@ cmake(
         "CMAKE_INSTALL_LIBDIR": "lib",
         "HAVE_SUBUNIT": "0",
     },
+    generate_args = [
+        "-GNinja",
+        "-DCMAKE_OSX_DEPLOYMENT_TARGET=13.0",
+    ],
     lib_source = ":srcs",
     linkopts = select({
         "@bazel_tools//src/conditions:darwin": ["-lpthread"],

third_party/nlopt.BUILD

@@ -26,6 +26,8 @@ cmake(
         "CMAKE_INSTALL_LIBDIR": "lib",
     },
     generate_args = [
+        "-GNinja",
+        "-DCMAKE_OSX_DEPLOYMENT_TARGET=13.0",
         "-DBUILD_SHARED_LIBS=OFF",
         "-DNLOPT_PYTHON=OFF",
         "-DNLOPT_OCTAVE=OFF",