Skip to content

Update from Ubuntu 18 (gcc-6, clang-6) to Ubuntu 20 (gcc-7, clang-6) [AP-3178] #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Update from Ubuntu 18 (gcc-6, clang-6) to Ubuntu 20 (gcc-7, clang-6) [AP-3178] #1473

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45214d9
Update Ubuntu 18 stage to Ubuntu 24
sbmueller Feb 12, 2025
538354a
Add privileges
sbmueller Feb 12, 2025
0258640
Add excluded build element in matrix
sbmueller Feb 12, 2025
8e7e48f
Switch to Ubuntu 20 with gcc 7 and clang 6
sbmueller Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions .github/workflows/c.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,28 +12,25 @@ on:
- "c/**"
- .github/workflows/c.yaml
jobs:

ubuntu-lts:

strategy:
matrix:
build_type: [ "Debug", "Release" ]
compiler: [
{ c: "gcc-6", cxx: "g++-6", package: "gcc-6 g++-6" },
{ c: "clang-6.0", cxx: "clang++-6.0", package: "clang-6.0" }
]
build_shared_libraries: [ true, false ]
exclude: [
Copy link
Contributor Author

@sbmueller sbmueller Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I digged in the history and this combination was excluded because at some point, there was a "code coverage" job that covered this combination. This job is not existing anymore, so I'm adding the combination again.

{ build_type: "Debug", compiler: { c: "gcc-6", cxx: "g++-6" }, build_shared_libraries: false }
]

name: "Ubuntu 18.04 (Build: ${{ matrix.build_type }}, Compilers: ${{ matrix.compiler.c }}/${{ matrix.compiler.cxx }}, Shared Library: ${{ matrix.build_shared_libraries }})"

build_type: ["Debug", "Release"]
compiler:
[
{ c: "gcc-7", cxx: "g++-7", package: "gcc-7 g++-7" },
{ c: "clang-6.0", cxx: "clang++-6.0", package: "clang-6.0" },
]
build_shared_libraries: [true, false]

name: "Ubuntu 20.04 (Build: ${{ matrix.build_type }}, Compilers: ${{ matrix.compiler.c }}/${{ matrix.compiler.cxx }}, Shared Library: ${{ matrix.build_shared_libraries }})"

# We run on a docker image to avoid being affected from GitHub
# decommissioning certain runners
runs-on: ubuntu-latest
container: ubuntu:18.04
container: ubuntu:20.04

steps:

- name: Setup
run: |
apt-get -qq update
Expand Down Expand Up @@ -66,7 +63,7 @@ jobs:
-DBUILD_EXAMPLES=true

- name: Build
run: cmake --build build --parallel
run: cmake --build build --parallel

- name: Example
run: cmake --build build --parallel --target examples
Expand Down Expand Up @@ -114,7 +111,6 @@ jobs:
cmake -S c/test_package -B c/test_package/build -DCMAKE_PREFIX_PATH="${{ github.workspace }}/install"
cmake --build c/test_package/build


big-endian:
name: Test Big Endian
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -157,7 +153,6 @@ jobs:
run: |
bazel test //...


asan:
name: ASAN
runs-on: ubuntu-20.04
Expand All @@ -178,7 +173,6 @@ jobs:
run: |
bazel test --config=asan //...


ubsan:
name: UBSAN
runs-on: ubuntu-20.04
Expand All @@ -199,12 +193,11 @@ jobs:
run: |
bazel test --config=ubsan //...


windows-2019:
strategy:
matrix:
generator: [ "MinGW Makefiles", "Visual Studio 16 2019" ]
build_shared_libraries: [ true, false ]
generator: ["MinGW Makefiles", "Visual Studio 16 2019"]
build_shared_libraries: [true, false]
name: "Windows 2019 (Generator: ${{ matrix.generator }}, Shared Library: ${{ matrix.build_shared_libraries }})"
runs-on: windows-2019
steps:
Expand Down Expand Up @@ -239,4 +232,3 @@ jobs:
run: |
cmake -G "${{ matrix.generator }}" -S c/test_package -B c/test_package/build -DCMAKE_PREFIX_PATH="${{ github.workspace }}/install"
cmake --build c/test_package/build

Loading