Fix NULL ptr deref in ipc_describe_workspace
#8868
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hot-plugging monitor(s) `ipc_json_describe_workspace` can end up dereferencing a NULL ptr in `wlr_output->name`. Here we simply check that it is set. While this is probably a race and just checking that it is not NULL before accessing it won't fully solve the race, it should make it substantially more rare. Mostly addresses swaywm#8747
|
I would prefer to find the root cause of this NULL pointer instead of adding a workaround. |
|
Sure, don't disagree, but absent someone having time to dig into it probably worth at least making sway stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hot-plugging monitor(s)
ipc_json_describe_workspacecan end up dereferencing a NULL ptr inwlr_output->name. Here we simply check that it is set.While this is probably a race and just checking that it is not NULL before accessing it won't fully solve the race, it should make it substantially more rare.
Mostly addresses #8747