output: Log output information when connected #8784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
We only use wlr_output fields to generate the identifier, and a later commit will use this function before a sway_output is constructed.
The only logging we currently provide about outputs is debug logging from wlroots about available modes, tested output states and errors applying it. Be more informative by logging some output details at INFO level when they pop up, including optional features like HDR and adaptive sync. This makes such output details more obvious from a quick glance, both for users and in case logs are shared for support.
kennylevinsen
force-pushed
the
output-log
branch
from
9f7dde7 to
273c122
Compare
|
I don't think this is a good place to surface back output capabilities to users. This PR also duplicates some information with wlroots logs. |
You can say that with most info logging though, including wlroots' own logging on the same topic of output details (detected modes, physical size).
Physical size, yeah. I had missed that the wlroots logging was WLR_INFO, recalled it as being WLR_DEBUG. Hmm, we could just add a few extra lines to the wlroots logging when discovering the connector... Then it's in one place for all wlroots compositors. |
|
Related: #8795 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only logging we currently provide about outputs is debug logging
from wlroots about available modes, tested output states and errors
applying it.
Be more informative by logging some output details at INFO level when
they pop up, including optional features like HDR and adaptive sync.
This makes such output details more obvious from a quick glance, both
for users and in case logs are shared for support.