Add unit ppt to 'move' + direction #8743
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Aug 5, 2025
| char *inv; | ||
| move_amt = (int)strtol(argv[0], &inv, 10); | ||
| if (*inv != '\0' && strcasecmp(inv, "px") != 0) { | ||
| if (*inv != '\0') { |
There was a problem hiding this comment.
Seems like this doesn't accept the px suffix anymore?
We already have a parse_movement_amount() function to parse an amount of px/ppt, could we re-use it here?
| Moves the focused container in the direction specified. The optional _px_ | ||
| argument specifies how many pixels to move the container. If unspecified, | ||
| the default is 10 pixels. Pixels are ignored when moving tiled containers. | ||
| *move* left|right|up|down [<px> [px|ppt]] |
There was a problem hiding this comment.
Probably should read <amount> instead of <px>?
Comment on lines
+706
to
+709
| //DEBUG | ||
| for (int i = 0; i < argc; i++) { | ||
| printf("argv[%d]: %s\n", i, argv[i]); | ||
| } |
There was a problem hiding this comment.
Remnant from debugging session?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literally the same pull request as #8596 that tries to solve #8566 but i don't know how to use github and couldn't find a way to just change the branch name. Anyway sorry ! (I also cleaned up the commits to use rebases instead of merges)