Remove mouse button event name validation #8709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some MMO mouse devices feature a large number of additional buttons. The Mad Catz MMO TE for example has 20 total mouse buttons, generating event codes from 272-292. Some of these event codes (279-288) have undefined event names. When using 'bindcode' to attempt to bind these events to actions, Sway currently attempts to validate that the corresponding event has a name beginning with 'BTN_'. This change removes that validation check. I'm not certain this is the right way to solve this problem for these mouse devices, but I've confirmed that this change allows buttons with undefined event names to be bound with 'bindcode' and I can't see anything else that might be affected by this change.
felixthacker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some MMO mouse devices feature a large number of additional buttons. The Mad Catz MMO TE for example has 20 total mouse buttons, generating event codes from 272-292. Some of these event codes (279-288) have undefined event names. When using 'bindcode' to attempt to bind these events to actions, Sway currently attempts to validate that the corresponding event has a name beginning with 'BTN_'. This change removes that validation check.
I'm not certain this is the right way to solve this problem for these mouse devices, but I've confirmed that this change allows buttons with undefined event names to be bound with 'bindcode' and I can't see anything else that might be affected by this change.