Add developer logs using log-base library #2537
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsebek
commented
Jul 20, 2025
| when ticked hypotheticalWinCheck' | ||
| return ticked | ||
| Effect.localData ["tick" Effect..= time] $ do | ||
| Effect.logTrace_ "Running tick" |
There was a problem hiding this comment.
byorgey
reviewed
Jul 20, 2025
| { startPaused = pausedAtStart | ||
| , pauseOnObjectiveCompletion = autoShowObjectives | ||
| , loadTestScenarios = Set.member LoadTestingScenarios debugOptions | ||
| , startLogging = True |
There was a problem hiding this comment.
Does startLogging ever get set to False? Will the game just be always writing out a log to disk by default?
There was a problem hiding this comment.
Oh, I should add a command line option or maybe finally add a config file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.