Skip to content

feat: support using, link top-level using declarations in components to lifecycle #16192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jun 17, 2025

Alternative to #16190, with the distinction that using declarations at the top level of a component are only disposed when the component unmounts.

I think I prefer this — it's more useful and more intuitive. Demo here.

On the server it doesn't transform anything, meaning resources are correctly disposed of once rendering is complete. Obviously all this is of limited use until support is sufficiently widespread, but I don't see any reason to hold it back until then. (The demo above actually works in all browsers, because top-level using gets compiled away for client code, but that doesn't apply to server code or non-top-level using.)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 17, 2025

🦋 Changeset detected

Latest commit: 8f5a073

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@Rich-Harris Rich-Harris mentioned this pull request Jun 17, 2025
6 tasks
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16192

@Rich-Harris Rich-Harris changed the title feat: support using, link top-level using declarations in components to lifecycle feat: support using, link top-level using declarations in components to lifecycle Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant