-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: ensure #if blocks correctly guard against nullable prop values #16140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Closes #16019, closes #16127
See #16019 for details.
On the failing test (
runtime-legacy/binding-this-legacy-component-api
): this one fails onmain
as well when using spread props, it fails on this PR because the logic that previously applied only on spread props logic now always applies. The$$events
prop needs to exist somewhere even when using the spread props proxy.Also, should investigate why #16019 (comment) isn't fixed
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint