remove PROXY_REMOVE_PATH #16126
Merged
remove PROXY_REMOVE_PATH #16126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6 tasks
|
Ocean-OS
approved these changes
Jun 10, 2025
|
Updated the implementation such that |
Rich-Harris
added a commit
that referenced
this pull request
Jun 10, 2025
* init * improve symbol logging * doh * remove proxy path name when reassigned to a source * try this * fix * oops * fix * "unown" proxy when in another source declaration * fix * tag proxy version * proxy bindable props * tag iterables used in destructuring * add changeset, fix failing tests * add comments, minor tweak * lint * somehow forgot to add support for class fields * more class fields * tag_source -> tag, since it applies to deriveds as well * private class fields * this condition is impossible * explicit type narrowing lets us avoid coercion * simplify * unused * tweak * oops, never meant to commit that * minor tweaks * fix private field tagging, only get `declaration` once * fix state declarations in constructors * fix * tag `svelte/reactivity`, `svelte/motion` sources in DEV * try fixing lint * fix intellisense formatting * actually fix lint * replace tag_if_necessary with conditional tagging * avoid [[object Object]] in labels * remove PROXY_REMOVE_PATH * simplify a bit * simplify * tweak * tweak implementation * tweak implementation * tweak implementation * hoist * tweak * fix * WIP (reduce number of with_parent calls, move towards possibility of combining tag and tag_proxy) * DRY out * tweak labels * remove PROXY_REMOVE_PATH (#16126) * remove PROXY_REMOVE_PATH * simplify a bit * simplify * tweak * tweak implementation * tweak implementation * tweak implementation * hoist * tweak * fix * WIP (reduce number of with_parent calls, move towards possibility of combining tag and tag_proxy) * DRY out * come on this was just lazy * fix tests --------- Co-authored-by: Rich Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's much value in removing the existing proxy path (#16060 (comment))