Skip to content

Conversation

namsnath
Copy link
Contributor

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

@namsnath namsnath self-assigned this Jun 10, 2025
@namsnath namsnath changed the base branch from 0.29 to 0.30 July 2, 2025 12:39
@namsnath namsnath force-pushed the feat/plugin/experiment branch from 2dee1be to ca412e5 Compare July 3, 2025 06:30
@namsnath namsnath requested review from sattvikc and porcellus July 3, 2025 09:45
@namsnath namsnath marked this pull request as ready for review July 7, 2025 05:20
Copy link

promptless bot commented Jul 7, 2025

✅ No documentation updates required.

Copy link
Collaborator

@porcellus porcellus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the broad strokes, those LGTM. Will wait for an in-depth review from @sattvikc

@namsnath
Copy link
Contributor Author

Hi @sattvikc ,
Addressed the comments in the last few commits

  • Redefined exports using __all__ in __init__ files to clean them up and make them consistent
  • Added old class names as aliases for backward compatibility

For the comments about quoted types, these are mainly to fix circular import issues since types used in classes need to be imported for use, or annotated (as done here)
Added some model_rebuild calls to fix Pydantic errors due to the annotated types

@namsnath namsnath requested a review from sattvikc July 23, 2025 12:12
@namsnath namsnath force-pushed the feat/plugin/experiment branch from 7b4083f to 5b1f37e Compare July 25, 2025 09:28
@namsnath namsnath changed the base branch from 0.30 to 0.31 July 29, 2025 11:24
- Adds dependency on `packaging` to compare versions
- Versions expected to follow PEP 440 style specifiers
- Sorts items in `setup.py` for clarity

ref: supertokens/supertokens-node#1021
- Uses a new `PluginRouteHandlerWithPluginId` class internally
- Adds a new `PluginError` and handles similar to `BadInputError`
- Makes `handler` functions async to be consistent with Node

ref: supertokens/supertokens-node#1021
@namsnath namsnath requested a review from porcellus August 20, 2025 12:22
@namsnath namsnath merged commit da78c98 into 0.31 Aug 21, 2025
1833 of 1876 checks passed
@namsnath namsnath deleted the feat/plugin/experiment branch August 21, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants